Accepts empty password on new wallet and account creation

Open manan-m-shah opened this issue 1 year ago • 4 comments

Not sure if it's intentional, but the commands below are accepting empty passwords.

forc wallet new forc wallet account new

Can quickly patch this if required.

May 02 '24 08:05 manan-m-shah

I think we can disallow empty passwords as a security measure. cc @FuelLabs/tooling for ideatation

May 02 '24 19:05 kayagokalp

@manan-m-shah are you still interested in implementing this? I think we want this implemented, and will likely look into it in coming weeks. If you want to take a shot, go for it!

Jun 09 '24 00:06 kayagokalp

I agree, this would be a good security measure. This code changes will be in https://github.com/FuelLabs/forc-wallet

Jun 13 '24 16:06 sdankel