smartparens icon indicating copy to clipboard operation
smartparens copied to clipboard

`M-j` key binding to `'sp-join-sexp` is shadowing emacs' `'comment-indent-new-line`

Open RockyRoad29 opened this issue 4 years ago • 0 comments

When editing multi-line comments (/* ... */ or /** ... */ for js-doc ), I found that the comment 'comment-indent-new-line would be helpful.

Unfortunately, its standard key binding M-j didn't work for me, neither C-M-j.

I found that they are shadowed respectively - by sp-join-sexp in smartparens mode. - and evil-mc-make-cursor-move-next-line

Both I seldom use for now and it's much annoying when you don't know what's going on. However, I believe they would be very useful as well and I don't want to discard them.

For me, M-J is free, and would suit well here, as J joins lines in evil's normal state.

I don't know yet what is the cleanest way to adjust it locally.

As it might concern many users (unless they have a better way to type javadoc-like comments, please let me know), I decided to post an issue.

At the moment, as a quick workaround in spacemacs, I toggle smartparens-mode as needed with SPC t p . A bit of a pity, isn't it ?

Expected behavior

M-j keeping is previous keybinding.

Actual behavior

M-j bound to sp-join-sexp.

Steps to reproduce the problem

Toggle smartparens-mode on and off.

Environment & version information

  • smartparens version: 20200105.1259
  • Active major-mode: emacs-lisp-mode
  • Smartparens strict mode: nil
  • Emacs version (M-x emacs-version): GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.10) of 2019-08-29
  • Starterkit/Distribution: Spacemacs
  • OS: gnu/linux

RockyRoad29 avatar Apr 20 '20 16:04 RockyRoad29