Matus Goljer

Results 723 comments of Matus Goljer

Can't get undercover to work, it alawys gives me ``` UNDERCOVER: No coverage information. Make sure that your files are not compiled? ``` I don't see anything that should compile...

So the problem was with doing `-l dash.el` etc... it has to be loaded via `require` in the code. Still I can only pick up `dash-functional` and not `dash` itself....

That's a good idea. I'm finishing next smartparens release now so I'll probably spend the weekend on that. Do you want to try and get this separated?

First of all, om.el seems like extremly rad package! I started something similar on my own (https://github.com/Fuco1/orgba), targeting more of org not just the elements, but I'm going to drop...

I think it is appropriate, but I would rename `&key` to `&plist` to correspond with `-lambda` signature. That's why I mentioned implementing it via `-lambda` which will keep it consistent...

I have no problems with this.

Speaking about benchmarks, if we're going to be doing such an optimization project, it would make sense to prepare some suite we could run automatically, ideally covering all the functions....

I guess it has lot to do with GC and other internals too... there might be some ways to prepare "good states", or alternatively always run in a clean emacs...

This PR has got quite big. Would you be so kind and split it into two (ideally one commit per function), one for the optimization thing and another for the...

So basically you map, sort with remembering the order and then unmap?