Surya Asriadie comments

Results 101 comments of


                                            Surya Asriadie

Add method to alter table column

I see, hmm maybe let's go for panic now? and adds some comment on the alter function?

Add method to alter table column

okay, then let's align with sqlite3

Add method to alter table column

@lafriks is this ready to be merged?

Add method to alter table column

> Should this be merged only when all related repo changed are done? I prefer this, after all merged, we can update `go.mod` on separate PRs to point to tagged...

Extend Adapter interface to include function to return adapter name

could you give examples? and is the database type specific code will be in sql package?

Extend Adapter interface to include function to return adapter name

got it, I think it's should be okay to add some metadata information like this I prefer `func Name() string`, and maybe have a constant (ex: `Name`) in each adapter...

Extend Adapter interface to include function to return adapter name

@lafriks need to be updated too https://github.com/go-rel/reltest/blob/main/nop_adapter.go https://github.com/go-rel/mssql

Allow to manually specify field names that need to be updated

probably we also need to provide exclude function?

Allow to manually specify field names that need to be updated

maybe as pointer: - define a mutator, example: https://github.com/go-rel/rel/blob/master/on_conflict.go#L13 - register the mutator here: https://github.com/go-rel/rel/blob/master/mutation.go#L31 - use mutator here: https://github.com/go-rel/rel/blob/master/structset.go#L32 there's also map type: https://github.com/go-rel/rel/blob/master/map.go#L22

ERROR: duplicate key value violates unique constraint "pg_class_relname_nsp_index"

will adding the lock statement manually before create table solve your issue? example: ``` func MigrateCreateTodos(schema *rel.Schema) { schema.Do(func(ctx context.Context, repo rel.Repository) error { return repo.Exec(ctx, "LOCK TABLE pg_catalog.pg_namespace IN...