Joel Kuntz comments

Results 47 comments of


                                            Joel Kuntz

Audit Dispose pattern in the codebase and add it to the style guide for reference

@AkashGutha https://github.com/github-for-unity/Unity/blob/master/docs/contributing/styleguide.md

Register package on Bower

http://bower.io/docs/creating-packages/ I don't make the tags via command line but rather through github releases and then Bower will automatically know when you push a new version

ArgumentOutOfRangeException: Length cannot be less than zero.

Hi @Kayumiy I suspect your issue may have been fixed with PR #9 I haven't released to the asset store yet but you can use this repo directly for now...

HMD Bug in Steam VR (Open VR)

Hi @Wandergin I suspect your issue may have been fixed with PR #9 I haven't released to the asset store yet but you can use this repo directly for now...

Add DRAW_FOCUS_PRESSED to facilitate font_focus_pressed_color on Button

Hi @KoBeWi, Thank you for the feedback, I appreciate it! I have opened a proposal and hopefully explain the use case a bit better 🙂 https://github.com/godotengine/godot-proposals/issues/9650 > This makes hover...

Add docs note about remap returning undefined when istart == istop

@kleonc thanks for diving in! I will update this PR to add tests for those cases, as well as update the docs to mention them. Is [[1]](https://stackoverflow.com/a/42926875) an issue the...

Add docs note about remap returning undefined when istart == istop

@kleonc thanks for the suggestion, I've updated the PR to match

Look into why icon isn't showing up

Apparently this is part of the new UI update mentioned [here](https://groups.google.com/a/chromium.org/forum/#!topic/chromium-extensions/7As9MKhav5E%5B1-25%5D) However it doesn't seem to work as described. Even when explicitly calling `chrome.pageAction.hide(tabId)`. I have posted on their dev...

Look into why icon isn't showing up

Also update the README/screenshots