Filtering works, but mute does not

[MikeDash]

trafficstars

:bug: Description

Advanced Profanity Filter is amazing - thank-you! It works with almost every site we throw at it. I have come across a couple of sites where the filtering works, but the muting does not.

:twisted_rightwards_arrows: Steps To Reproduce

Default settings in APF go to ctv.ca play video when a word in the list is found it will be substituted but audio will not mute.

I tried all methods of muting.

I was able to get it working in watcher mode with this:

{
  "www.ctv.ca": {
    "mode": "watcher",
    "checkInterval": 1,
    "filterSubtitles": true,
    "showSubtitles": true,
    "muteMethod": 0,
    "parentSelector": "div.jw-text-track-container",
    "subtitleSelector": "div.jw-text-track-display"
  }
}

Here is an example node:

​

​

​Subtitles go here

​

​

​

With the special audio config above it works, but isn't really supposed to show the substituted subtitles, as they flash and jitter as they are updated.

What baffles me is why the default settings work but don't mute? It appears to maybe be something related to one of the objects used by the mute function being null.

:heavy_check_mark: Expected behavior

Mute when filtered word is found.

Chrome APF 2.36.4

Thank-you for all your amazing work on this project.

[richardfrost]

Thanks for reporting the issue @MikeDash! I am not familiar with this site, and it doesn't look like its been requested (or supported) before, but I'm always happy to add support for more sites! Good work on figuring out a watcher method that mostly works for the site! I'm working on an overhaul of the watcher method right now, and making some improvements with the hiding/showing that could hopefully help out with that issue.

I will try to take a look at the site in the next few days, but I've been really busy this week and can't promise anything. I'm also hoping to wrap up that big overhaul of the watcher mode code that should help, but still has quite a bit of work left. Anyway, thanks again for reporting the issue, and I'm pretty sure we'll be able to get a good filter working for it soon.

[winiarnold]

Richard Frost, I am new to this plug in and would be happy to support this project should I am able to get it to function correctly. I have downloaded the plugin and created Wordlist etc. However, audio mute nor word removal is working in Netflix.

Thank you for your help.

Wini Arnold

[richardfrost]

Welcome @winiarnold.

I've created an issue for this problem you brought up: #428. Please see it to see some questions I have that will hopefully help us get it working for you.

[elaineroot]

Hello, I can not seem to get amazon prime to mute a couple phrases I want it to. Could I please get help? Thank you!

[richardfrost]

Hi @elaineroot, I'm sorry it isn't working for you. Could you share an example video where the filtering isn't working, and the approximate time in the video? Is muting working on other words/phrases in the video?

[elaineroot]

sorry season 6 episode 24 around 24 minutes into the video

On Wed, Sep 7, 2022 at 3:28 PM Richard Frost @.***> wrote:

Hi @elaineroot https://github.com/elaineroot, I'm sorry it isn't working for you. Could you share an example video where the filtering isn't working, and the approximate time in the video? Is muting working on other words/phrases in the video?

— Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/426#issuecomment-1239971332, or unsubscribe https://github.com/notifications/unsubscribe-auth/A26R3H4RESNWSNHERM3GC2DV5EJHZANCNFSM56H3KBCQ . You are receiving this because you were mentioned.Message ID: @.***>

[richardfrost]

@elaineroot Sorry, what video/series is this? Do you think you could just include a link to it?

[elaineroot]

Yes. I’m not sure if you saw my first email but I talked about it more there and about the at the video series was. thank you and here’s the link https://watch.amazon.com/detail?gti=amzn1.dv.gti.96a9f75a-2483-5d81-ec57-c6835b037415&territory=US&ref_=share_ios_season&r=web On Fri, Sep 9, 2022 at 3:29 PM Richard Frost @.***> wrote:

@elaineroot https://github.com/elaineroot Sorry, what video/series is this? Do you think you could just include a link to it?

— Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/426#issuecomment-1242527815, or unsubscribe https://github.com/notifications/unsubscribe-auth/A26R3H23DMK3GLEVZDI5R5TV5O23ZANCNFSM56H3KBCQ . You are receiving this because you were mentioned.Message ID: @.***>

[elaineroot]

Hello, Was wondering if you where able to figure out why it isn’t working. It is not working on the Heartland series on Amazon prime either. Could it be because they are hosted by Frevee on Amazon Prime?! Thank you! Elaine

On Wed, Sep 7, 2022 at 3:28 PM Richard Frost @.***> wrote:

Hi @elaineroot https://github.com/elaineroot, I'm sorry it isn't working for you. Could you share an example video where the filtering isn't working, and the approximate time in the video? Is muting working on other words/phrases in the video?

— Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/426#issuecomment-1239971332, or unsubscribe https://github.com/notifications/unsubscribe-auth/A26R3H4RESNWSNHERM3GC2DV5EJHZANCNFSM56H3KBCQ . You are receiving this because you were mentioned.Message ID: @.***>

[richardfrost]

HI @elaineroot, sorry for the delay with this. I just tested again and it looks like its working for me. Which Country are you watching from? Also, which web browser are you using? Could you send me a copy of your APF config? You can get it by going to the extension's Options page > Config tab > Export button.

[elaineroot]

Hello, No problem! Thank you for looking into it for me! I am From the USA. I am using microsoft edge. Also, I forgot my password😭 Ao I can’t sign in now🤦‍♀️ Thank you! Elaine

On Wed, Sep 28, 2022 at 8:44 PM Richard Frost @.***> wrote:

HI @elaineroot https://github.com/elaineroot, sorry for the delay with this. I just tested again and it looks like its working for me. Which Country are you watching from? Also, which web browser are you using? Could you send me a copy of your APF config? You can get it by going to the extension's Options page > Config tab > Export button.

— Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/426#issuecomment-1261717219, or unsubscribe https://github.com/notifications/unsubscribe-auth/A26R3H5LT62SRKJPC3NEVW3WAUGA3ANCNFSM56H3KBCQ . You are receiving this because you were mentioned.Message ID: @.***>

[elaineroot]

I don’t see a place to reset password. Not sure what to do!

On Wed, Sep 28, 2022 at 11:25 PM Elaine Root @.***> wrote:

Hello, No problem! Thank you for looking into it for me! I am From the USA. I am using microsoft edge. Also, I forgot my password😭 Ao I can’t sign in now🤦‍♀️ Thank you! Elaine

On Wed, Sep 28, 2022 at 8:44 PM Richard Frost @.***> wrote:

HI @elaineroot https://github.com/elaineroot, sorry for the delay with this. I just tested again and it looks like its working for me. Which Country are you watching from? Also, which web browser are you using? Could you send me a copy of your APF config? You can get it by going to the extension's Options page > Config tab > Export button.

— Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/426#issuecomment-1261717219, or unsubscribe https://github.com/notifications/unsubscribe-auth/A26R3H5LT62SRKJPC3NEVW3WAUGA3ANCNFSM56H3KBCQ . You are receiving this because you were mentioned.Message ID: @.***>

[richardfrost]

@elaineroot Did you forget your password for the Extension?

[elaineroot]

Yes🤦‍♀️

On Wed, Sep 28, 2022 at 11:40 PM Richard Frost @.***> wrote:

@elaineroot https://github.com/elaineroot Did you forget your password for the Extension?

— Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/426#issuecomment-1261834947, or unsubscribe https://github.com/notifications/unsubscribe-auth/A26R3H3WBD6G6SILD63VDPDWAU2WRANCNFSM56H3KBCQ . You are receiving this because you were mentioned.Message ID: @.***>

[richardfrost]

@elaineroot send an email to apf @ frostco.dev (without spaces) and I'll help you recover it.

[elaineroot]

well I don’t know because I was trying it out and seeing if it would take out the oh my god and oh my lord. So it is amazon prime and as far as I know I have the settings right so it should. I know it’s doing something because i turned on the subtitles on prime so it would work and then choose the option for the subtitles not to show on your add on and they aren’t showing so it’s definitely connected. the episode i was watching was little house on the Prairie season 6 episode around 24 minutes into the episode! thank you for your help!!

On Wed, Sep 7, 2022 at 3:28 PM Richard Frost @.***> wrote:

Hi @elaineroot https://github.com/elaineroot, I'm sorry it isn't working for you. Could you share an example video where the filtering isn't working, and the approximate time in the video? Is muting working on other words/phrases in the video?

— Reply to this email directly, view it on GitHub https://github.com/richardfrost/AdvancedProfanityFilter/issues/426#issuecomment-1239971332, or unsubscribe https://github.com/notifications/unsubscribe-auth/A26R3H4RESNWSNHERM3GC2DV5EJHZANCNFSM56H3KBCQ . You are receiving this because you were mentioned.Message ID: @.***>