miniz_oxide icon indicating copy to clipboard operation
miniz_oxide copied to clipboard

`adler` is archived

Open smoelius opened this issue 1 year ago • 3 comments

As of yesterday, it seems: https://github.com/jonas-schievink/adler

EDIT: adler is relied upon here: https://github.com/Frommi/miniz_oxide/blob/79307d7bd6e4aa3e86b30fd225a00ecb412188a4/miniz_oxide/Cargo.toml#L20

smoelius avatar Mar 26 '24 13:03 smoelius

Hm. I don't know whether this is an issue or not. There aren't really any alternatives atm as simd-adler32 uses unsafe (due to the use of manual SIMD code) hence why it's an optional feature, and the reason we moved to the adler crate from adler32 originally was due to licensing differences. (The adler32 git has it's last update even further back.)

I guess we'd need to fork it or ask if it would be possible to take over the crate or something if an update is be needed. Judging by the benches at the simd-adler32 page it's possible there are some performance improvements that could be done even if explicit SIMD can't be used due to unsafe. (ofc using the simd feature which uses simd-adler32 will speed up things more if that's important, and one is using the zlib wrapper specifically.)

For that matter miniz_oxide could probably benefit being moved/transfered to an org or something as well as I'm basically the sole maintainer currently, not sure if @Frommi is accessible these days.

oyvindln avatar Mar 30 '24 00:03 oyvindln

For that matter miniz_oxide could probably benefit being moved/transfered to an org or something

FWIW, miniz_oxide appears in my projects' dependency trees under anyhow >> backtrace and gix >> ... >> flate2.

... I'm basically the sole maintainer currently ...

Thank you for that! :pray:

smoelius avatar Apr 02 '24 10:04 smoelius

I've mentioned this issue and general problem at https://github.com/rustsec/advisory-db/issues/1992

jayvdb avatar Jul 03 '24 03:07 jayvdb

Should this be closed now, as it seems like adler2 is being depended on?

GnomedDev avatar Sep 10 '24 10:09 GnomedDev

Yup, just forgot to add it to the commits

oyvindln avatar Sep 10 '24 20:09 oyvindln