miniz_oxide

miniz_oxide copied to clipboard

miniz_oxide doesn't validate HLIT

3

The deflate spec requires that dynamic blocks contain at most 286 length/literal codes, despite the encoding allowing values up to 288 to be represented: > We can now define the...

fintelia

Is TINFL_FLAG_HAS_MORE_INPUT necessary?

1

https://github.com/Frommi/miniz_oxide/blob/7f5aedd7cc553b624902210a7d136440c138dc80/miniz_oxide/src/inflate/core.rs#L600-L607 It seems like the flag only serves to rename the `NeedsMoreInput` variant to `FailedCannotMakeProgress` at runtime. Both of the errors only seem to be created in this function. The...

Plecra

Continuing from #29: `inflate::decompress_to_vec()` has its own fuzzing target and is covered pretty well. There should also be a fuzzing target for the streaming API.

Shnatsel

There's still some unsafe usage in the C API glue that could be avoided, such as raw memory allocation. Eventually we want to fully fix #16, but the innter C...

oyvindln

Make C API layout-compatible with miniz

2

The README mentions that exporting miniz-compatible headers is blocked on an upstream cbindgen issue. However, a workaround for that issue was devised: https://github.com/eqrion/cbindgen/issues/326#issuecomment-584288686 So it should be possible to export...

Shnatsel

Improve block type selection algorithm

2

I am currently developing a library that uses data compression, and to handle that task I have chosen to use the **flate2** crate with its default compression backend, **miniz_oxide**. While...

claudiosdc

Create a cleaner/easier API

1

The current API was strung together to first sit under the miniz-compatible C API, and modified slightly later to avoid going via C and unsafe for the flate2 front-end. Other...

oyvindln

`println!()` can cause panic outside `catch_unwind()`

1

The `miniz_oxide_c_api` wrappers in `src/lib.rs` call `println!("FATAL ERROR: Caught panic!");` when a panic is caught. `println!()` can panic if it fails to write, causing UB if `panic = "abort"` is...

LegionMammal978

Performance

26

@oyvindln, can you please give a link for your performance tests? - adler32(crc) vectorization. I rewrote the shortest version. - Also, when rewriting I skipped on copying fields from compressor/decompressor...

Frommi

Docs of `miniz_oxide::inflate::core::decompress` seem slightly stale

1

The docs of [decompress](https://docs.rs/miniz_oxide/0.5.0/miniz_oxide/inflate/core/fn.decompress.html) mention `out_cur` in several places, but this isn't a named argument of the function, nor does it appear to be one of the implied fields of...

Lokathor