Lukas Senionis

> > (I really should go to sleep...) > > Hope you got some rest, now I'm the one way past the bedtime I got slightly sick :D Got a...

Stop commiting and go to sleep!

1. Hmmm, conversion could look like this (maybe we should add a static method `static rational_t fromFloat(float value)` so that it can be improved later on): `numerator = static_cast(value *...

I think I am (or we) approaching this from a wrong point. We don't need to expose the mode structure at all (I would prefer to keep it hidden at...

> Looks perfect to me. I'd use resolution_scale to make it explicit, and probably I'd add to device_info_t the std::string id, instead of only relying on it as the key...

Heyo, I have reached a point where I am implementing the last function for the OS abstraction layer - the enumeration function. After thinking for a while, I would like...

> Sorry for seemingly out-of-nowhere comment > > ```c++ > struct Info { > Resolution m_resolution {}; /**< Resolution of an active device. */ > float m_resolution_scale {}; /**< Resolution...

FYI, I have already finalized the "public" types and am happy about them (for now): https://github.com/LizardByte/libdisplaydevice/blob/master/src/common/include/displaydevice/types.h

In my specific case, the denominator is always 10 to the power of `x`. For converting floating point back to rational, I luckily do not need to be too precise...

In any case the user would input the refresh rate as a string/number (e.g. `59.9885`) that would have to be manually converted to the rational anyway, so I've decided to...