rpfm icon indicating copy to clipboard operation
rpfm copied to clipboard

cli: No updates available for schema shouldn't be an error

Open bukowa opened this issue 11 months ago • 3 comments

I am just setting up Makefile for building mod and I encounter this issue when up-to-date schema causes error. I believe this is a mistake, and it should be just a warning.

https://github.com/Frodo45127/rpfm/blob/e1fa95bfc17a09c3b51bebe95b1fa0e1519ac3f1/rpfm_lib/src/integrations/git.rs#L201-L215

$ make init
cd ./contrib/rpfm && \
        rpfm_cli --game rome_2 schemas update --schema-path ./
17:28:13 [INFO] Logger initialized.
17:28:13 [INFO] Sentry Logging support enabled. Starting...
17:28:14 [ERROR] No updates available for the following git repository: https://github.com/Frodo45127/rpfm-schemas.
make: *** [init] Error 1

bukowa avatar Feb 17 '25 17:02 bukowa

I have vague memories of this. The theory was that, when that code was written, that function could not be called unless it had first passed through the check_updates function and that one had returned that there were updates. Meaning if there are updates but a second later there are not, it's an error.

That's not the case anymore, so yes, it should return an Ok, but with either a message or an enum saying that it was ok because there were no updates. Other it may cause a silent failure when there are updates, but something else fails giving the impression that there are no updates.

Frodo45127 avatar Feb 18 '25 04:02 Frodo45127

Ok seems like a good first issue to fire that rust and start fiddling with rpfm I think it would be very good to label this as "Good First Issue".

bukowa avatar Feb 18 '25 11:02 bukowa

Ok seems like a good first issue to fire that rust and start fiddling with rpfm I think it would be very good to label this as "Good First Issue".

Done. I actually didn't had that label in the label list...

Frodo45127 avatar Feb 22 '25 00:02 Frodo45127