fs-uae
fs-uae copied to clipboard
FrodeSolheim
SCP floppy image doesn't wrap to revolution #0 cleanly (includes patch)
A single-revolution generated SCP image containing a non-index-aligned track ought to be able to replay cleanly if flux is precisely accounted across the wrap-round. This isn't currently the case as "flux gap" from the last sample to the track-end time is currently lost. The patch I attach below fixes this. I also include an example SCP file which exhibits the issue.
The patch also fixes a long-standing bug where revolution #0 in a multi-revolution image gets played out twice when a track is first loaded. eg. in a four-rev file the emulator will see revs 0,0,1,2,3,0,1,2,3,0,1,2,3,...
I hope this can be added to FS-UAE and perhaps also pushed upstream to WinUAE in due course?
Thanks!
I also raised this to WinUAE https://github.com/tonioni/WinUAE/issues/186
It may be more appropriate for FS-UAE to take this fix from upstream if Toni will accept it to WinUAE this way.
Hi, I saw that the change was just accepted into WinUAE, so it will therefore eventually make its way into FS-UAE. But I will probably include this patch separately, since it will probably be a while until I'm up to date with the current WinUAE in-development code.
The patch has been included in git master (for 4.0.x) and also in the fs-uae-3.0-branch for a potential 3.0.6 release. Thanks! :)