Stéphane Épardaud
Stéphane Épardaud
I can add options for EC/RSA and key size. I wonder what the recommended key size is these days.
Well, if I add support for EC it's not `quarkus rsa` anymore, is it? So another command `quarkus ec`? Or `quarkus keygen`?
Changed to `genkey` added EC option and key size options. The defaults are fine according to https://www.keylength.com/en/compare/ Let's call it a day and merge this at some point ;)
Formatted and rebased
Huh, test fails with a generated key size of 256 when it should be 512. That's quite a margin of error. Damn.
The original issue was about creating private/public keys, used by JWT, but I got stuck because my code did not appear to pass the tests on Windows. If `tls` can...
> What's the requirement? Well, not sure what you ask, really. The original description sums is up pretty correctly: https://github.com/quarkusio/quarkus/pull/22182#issue-1079526928 I want to make it trivial for users to generate...
OK, indeed, plus they must be in two different files, I'm pretty sure. So, if you got TLS to generate valid public/private keys, I'm very interested in how you're testing...
So probably you don't test the certificates as I do. As long as they work… But that's the thing, I can't figure out if they have the proper required bits....
> It promotes the usage of io.quarkus.hibernate.reactive.panache.common.WithTransaction, which is now deprecated I don't see where it's deprecated :-/