Friz64

Results 73 comments of Friz64

It's interesting that (apparently/probably) since #11737 got merged, it now panics a second time. This is the full message: ``` thread 'Compute Task Pool (14)' panicked at crates/bevy_render/src/view/window/mod.rs:368:21: Couldn't get...

Bisected to #11660. cc @hymm Seems to only happen on X11 for me (ran through XWayland), Wayland directly works fine. I am running GNOME Wayland.

Unfortunately, I'm still getting the same issue.

```diff 2024-02-07T07:19:09.357857Z INFO bevy_winit::system: Closing window 0v1 exiting early thread 'Compute Task Pool (12)' panicked at crates/bevy_render/src/view/window/mod.rs:372:21: Couldn't get swap chain texture, operation unrecoverable: The swap chain has been lost...

> Could you add a println! after the 2 if's and see if it logs something after the "exiting early"? It does not log something.

It now panics twice on the main branch, see: https://github.com/bevyengine/bevy/issues/11811#issuecomment-1937259162 --- Also, I got curious and tried directly running it in an X11 session (so, without XWayland) to see if...

Minimal reproducer: ```rust use bevy::{prelude::*, window::WindowMode}; fn main() { App::new() .add_plugins(DefaultPlugins.set(WindowPlugin { primary_window: Some(Window { mode: WindowMode::Fullscreen, ..Default::default() }), ..Default::default() })) .run(); } ``` The problem is this unwrap: https://github.com/bevyengine/bevy/blob/a6574786757c0a0a7ddffb99fdc40ce90980fc82/crates/bevy_winit/src/winit_windows.rs#L62C80-L62C80...

Wayland doesn't have the concept of a "primary" monitor. We could try to find a fallback monitor. Maybe just the first one in the list of monitors? Maybe the one...

At least when changing the fullscreen mode during runtime, any exclusive fullscreen request just gets ignored (by winit). It's also worth thinking about if this behaviour is desired.

C-string literals have now landed in Rust 1.77.