Enable case lighting with caselight_on_at_startup
Using white caselights fcob_white, only the status lights on toolhead are enabled with the caselight_on_at_startup variable set to True.
This change turns on caselights using LIGHT_ON/LIGHT_OFF macros
hello, LIGHT_ON/LIGHT_OFF macros are only available when fcob_white is included and so light_enabled exist.
That's Ok like this for you because you have fcob_white AND status_leds
So, you must rework a little bit your PR to be correct:
Maybe:
[gcode_macro _INIT_LEDS]
gcode:
{% if printer["gcode_macro _USER_VARIABLES"].status_leds_enabled or printer["gcode_macro _USER_VARIABLES"].status_leds_caselight_enabled or printer["gcode_macro _USER_VARIABLES"].light_enabled %}
{% if printer["gcode_macro _USER_VARIABLES"].caselight_on_at_startup|default(False) %}
{% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
LIGHT_ON
{% endif %}
{% if printer["gcode_macro _USER_VARIABLES"].status_leds_enabled or printer["gcode_macro _USER_VARIABLES"].status_leds_caselight_enabled %}
STATUS_LEDS COLOR="READY"
{% endif %}
{% else %}
{% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
LIGHT_OFF
{% endif %}
{% if printer["gcode_macro _USER_VARIABLES"].status_leds_enabled or printer["gcode_macro _USER_VARIABLES"].status_leds_caselight_enabled %}
STATUS_LEDS COLOR="OFF"
{% endif %}
{% endif %}
{% endif %}
@Benoitone this seems like a sane change, I can update the PR. Thanks for your input
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!
ping
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!