klippain icon indicating copy to clipboard operation
klippain copied to clipboard

Option to use RGB caselights as status LEDs

Open teookie opened this issue 1 year ago • 8 comments

Modified calls to gcode macro STATUS_LED to also execute if user variable status_leds_caselight_enabled is true.

Also added variable status_leds_caselight_enabled to user variables file. If user sets this to true, then caselights will function as status LEDs. If set to false, then caselights will illuminate to their initial colors as called out in [neopixel caselight], but won't function as status LEDs.

(This is my first ever pull request on github - I hope I did it right.)

teookie avatar Mar 19 '24 12:03 teookie

Hello thanks for the PR! There is also #541 that was open. Can you have a look and see with Benoit which option is better and it could be made into a new PR that group both of the ideas?

Frix-x avatar Mar 20 '24 08:03 Frix-x

Hello thanks for the PR! There is also #541 that was open. Can you have a look and see with Benoit which option is better and it could be made into a new PR that group both of the ideas?

@teookie I don't understand exactly the utility of variable_status_leds_caselight_enabled in variables.cfg because if you have toolhead status_led also included, caselight (not Fcob) use also status leds macros... So I think if set to false/true nothing changes... The only utility is if you don't have toolhead status led... So maybe the other PR is a little bit simple and don't need to add another variable in variables.cfg?

PS: if you want to have different control between caselight and tool head status LEDs, many other things need to be reworked

Benoitone avatar Mar 21 '24 13:03 Benoitone

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar Apr 21 '24 07:04 github-actions[bot]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar May 21 '24 07:05 github-actions[bot]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar Jun 21 '24 07:06 github-actions[bot]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar Jul 21 '24 07:07 github-actions[bot]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar Aug 21 '24 07:08 github-actions[bot]