klippain Neopixel_caselight

if no toolhead light is selected in printer.cfg and only one of the 2 types of neopixel caselight is included then no lighting will be active in the macros.

Mar 09 '24 08:03 Benoitone

Hello there is also #561 that was open. Can you have a look and tell me which option is better? Or maybe merge both into a global new PR with the best of both?

I'm not using neopixels on my machines so I can't test that much this kind of things...

Mar 20 '24 08:03 Frix-x

Hello there is also #561 that was open. Can you have a look and tell me which option is better? Or maybe merge both into a global new PR with the best of both?

I'm not using neopixels on my machines so I can't test that much this kind of things...

Hello, I don't really see the point of adding a variable in variables.cfg... For me, the modification made solves the problem encountered and seems to me to be entirely compatible with the different possible configurations.

Mar 20 '24 19:03 Benoitone

@Frix-x @mattpolito maybe we can make a common PR with #563 : If @mattpolito want to make is PR modified in neopixel_caselight_enable branch??? with:

[gcode_macro _INIT_LEDS]
gcode:
    {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled or printer["gcode_macro _USER_VARIABLES"].light_enabled %}
        {% if printer["gcode_macro _USER_VARIABLES"].caselight_on_at_startup|default(False) %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_ON
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled %}
                STATUS_LEDS COLOR="READY"
            {% endif %}
        {% else %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_OFF
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled %}
                STATUS_LEDS COLOR="OFF"
            {% endif %}
        {% endif %}
    {% endif %}

Mar 21 '24 14:03 Benoitone