klippain icon indicating copy to clipboard operation
klippain copied to clipboard

added variable for timeout handling

Open Surion79 opened this issue 1 year ago • 5 comments

added variable to prevent calling M84 on timeout. With the G2Z beta, gantry sag is a potenial issue, especially if toolhead is located near the edges. with the introduced variable, it is now possible to prevent M84 on timeout.

it was copied based on the already existing end print variables, except that i did not added the heater off due to functional safety concerns.

Surion79 avatar Mar 03 '24 15:03 Surion79

Wouldn't this be a safety issue since a timeout means everything should usually stop to prevent a problem? Keeping the motors under power seems a bit counterproductive and would add a security flaw IMHO...

Frix-x avatar Mar 04 '24 08:03 Frix-x

my initial thought was that motors could stay on, but heater not over longer time. There are already some config options to change behaviour in timeout. Just adding the option to be able to change it without making it the default

Surion79 avatar Mar 04 '24 16:03 Surion79

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar Apr 04 '24 07:04 github-actions[bot]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar May 04 '24 07:05 github-actions[bot]

📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!

github-actions[bot] avatar Jun 03 '24 07:06 github-actions[bot]