klippain
klippain copied to clipboard
Frix-x
Klippain compatibility with HH v2.5
try to make klippain compatible with Happy_Hare v2.5 Actually in developpment in happy_hare variables branch
could you put this please in a draft state? Or can it be already integrated?
Instead of checking for mmu.enabled would it be possible via rename existing to set klippain mmu enabled to false/true if the related function in MMU is used?
i changed the base to develop, hopefully to prevent the issues of last time
For me it seems to be ok... The new HH version has been released today...
with this version use with HHv2.5+ no need to have to add entries in printer.cfg but if they exist they can override HH variables.
I'll do a couple of minor changes to change some wording in the documentation and also add warning that <v2.5 is deprecated and will be removed in the future. This way we will be able to keep the code base more clean by removing in a next Klippain version all the checks about the HH version
@Benoitone are the changes ok for you? Especially the startup change as I changed a bit the "if" logic to add the deprecation warning and not sure it's ok like this.
@Frix-x I rework a little bit yours startup modifications. I think it's ok now... can you check?
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days. We appreciate your contribution!
Hello @Benoitone , I'm coming back to the project and will work on merging this branch when you are ready :) Is there anything that needs to be updated before a full review?