klippain icon indicating copy to clipboard operation
klippain copied to clipboard

added AWD support (2x X, 2x Y)

Open Surion79 opened this issue 1 year ago • 5 comments

this adds additional config possibilities for "AWD" or multi driver per axis X and Y. (max 2 per axis) It is implemented like the Z implementation.

For not breaking, the original files reference to the "1-Motor" variant of the new files.

Surion79 avatar Feb 26 '24 17:02 Surion79

Thanks for the PR!

I think it's giving a lot of changes and there is already a lot ready for the new release. So if you don't mind, I'll merge it later when you get your motors and everything to test it properly :)

Frix-x avatar Feb 26 '24 22:02 Frix-x

I'm fine with it. I do need it merged in develop at 18th march 2024. then i have the last parts delivered. Motors are in about next week (ldo nema14 high temp). I won't be able to test all tmcs since i don't own 5160s. since it is derived from the newest develop version, it should have the correct parameters.

Surion79 avatar Feb 26 '24 22:02 Surion79

Hi there, I am trying to figure out if the AWD_XY branch is usable or if I should wait until this is merged to Main... I have the AWD-330 vzbot and would like to try out your suite when it's ready.

Kcdc3d avatar May 09 '24 18:05 Kcdc3d

due to personal stuff i wasn't able to test it out, although there is no coding per se involved. it is just configuration files for the additional X/Y motors. you can add the X1/Y1 sections to your overrides. you need to set the pins there manually then. Otherwise you can wait until it is finally merged

Surion79 avatar May 09 '24 18:05 Surion79

Ok I thought I saw a few files changed but after going back, it was just another driver setup for the second motor in The Axis Folder Thanks for clearing that up!

Kcdc3d avatar May 10 '24 02:05 Kcdc3d

Testing this now, we will also need a replacement for the default wiring imports in [include config/hardware/axis/X/1.8deg.cfg] so possible alongside [include config/hardware/axis/X/1.8deg_2-Motors.cfg], etc?

I can look at added something alongside tomorrow and I'll PR to this branch

tristanmcpherson avatar May 31 '24 05:05 tristanmcpherson

let me have a look

Surion79 avatar May 31 '24 05:05 Surion79

@tristanmcpherson mind testing again with the new addition? or is there something different missing as well? It is not possible to add templates like Z axis, as there is not really a typical AWD only builds for referencing

Surion79 avatar May 31 '24 06:05 Surion79

@tristanmcpherson mind testing again with the new addition? or is there something different missing as well? It is not possible to add templates like Z axis, as there is not really a typical AWD only builds for referencing

Working good with the new changes. Was the difference in file name for 0.9deg intentional? The space seems potentially problematic

tristanmcpherson avatar May 31 '24 06:05 tristanmcpherson

well, copy paste topic :D anything else? :)

Surion79 avatar May 31 '24 06:05 Surion79

Working good for me! I can confirm good enough to be merged @Frix-x

tristanmcpherson avatar May 31 '24 06:05 tristanmcpherson

Oh, we should add user template for the new motor configs in https://github.com/Frix-x/klippain/blob/main/user_templates/printer.cfg#L27

tristanmcpherson avatar May 31 '24 06:05 tristanmcpherson

added, anything else? :)

Surion79 avatar May 31 '24 07:05 Surion79

cheers and thanks for the updates

Kcdc3d avatar Jun 12 '24 03:06 Kcdc3d

i removed the whole "e.g." parts to make it more generic

Surion79 avatar Jun 19 '24 15:06 Surion79