klippain-shaketune icon indicating copy to clipboard operation
klippain-shaketune copied to clipboard

Allow to install klippain-shaketune in a given directory.

Open tsk-2222 opened this issue 2 years ago • 2 comments

Based on @arcadien's work on klippain. Thanks arcadien!

example: ./install.sh voron_2 or ./install.sh printer_8

Additionally, this needs an override or to be handled somehow:

[gcode_shell_command shaketune]
command: ~/printer_data/config/scripts/K-ShakeTune/shaketune.sh

If this script is acceptable, I also have the changes for klippain that are very similar.

tsk-2222 avatar Mar 05 '24 17:03 tsk-2222

I was hoping to get suggestions on how best to handle the lines below. These lines exist in shaketune.cfg and things will break if klippain is installed to ~/printer_8, etc.

[gcode_shell_command shaketune]
command: ~/printer_data/config/scripts/K-ShakeTune/shaketune.sh

It seems to me that an automatically populated entry in overrides.cfg would fix things. Any objections or better ideas?

tsk-2222 avatar May 24 '24 01:05 tsk-2222

Hello,

Sorry for the silence here, in fact I haven't replied yet as there has been a major rework for Shake&Tune that is almost finished now. You can find it in the development branch: it's now a fully integrated Klipper plugin.

So basically this is much easier for the install script, which now just symlinks files into the Klipper extras folder and installs the requirements into the klipper python venv. Then users just need to add [shaketune] to their config.

So I think your PR will need to be changed a bit to account for multi-klipper in this new way of installation, but it should be much easier in the end as there's no need for gcode_shell commands anymore... :)

Frix-x avatar May 24 '24 07:05 Frix-x