klippain-shaketune icon indicating copy to clipboard operation
klippain-shaketune copied to clipboard

improved dummy macros handling of spaces in parameters strings values

Open Frix-x opened this issue 7 months ago • 1 comments

Improve dummy macros parameter handling by removing empty-string fallbacks and applying xmlattr filtering to properly quote and escape values with spaces.

Enhancements:

  • Remove empty-string fallback logic for None macro parameters across dummy macros
  • Apply xmlattr filter to macro parameter outputs for proper quoting and escaping of values containing spaces

Frix-x avatar Sep 25 '25 11:09 Frix-x

Reviewer's Guide

This PR simplifies the dummy macro parameter mappings by removing explicit empty‐string fallbacks and applies the Jinja xmlattr filter to properly quote values containing spaces in the rendered G-code commands.

File-Level Changes

Change Details Files
Removed redundant conditional defaults in parameter dictionaries
  • Eliminated "if ... is not none else ''" wrappers for all optional params
  • Simplified assignments for ACCEL_PER_HZ, Z_HEIGHT, ACCEL_CHIP, FREQ_START, FREQ_END, MAX_SCALE, SCV, MAX_SMOOTHING
  • Unified behavior so undefined or None params simply remain None
  • Reduced boilerplate across all dummy macros
shaketune/dummy_macros.cfg
Applied xmlattr filter in Jinja loops for safe value quoting
  • Replaced {key}={value} with `{key}={{ value
xmlattr }}` in macro expansions
  • Ensured parameters with spaces are escaped and quoted properly
  • Updated loops in _EXCITATE_AXIS_AT_FREQ, _COMPARE_BELTS_RESPONSES, _AXES_SHAPER_CALIBRATION

  • Tips and commands

    Interacting with Sourcery

    • Trigger a new review: Comment @sourcery-ai review on the pull request.
    • Continue discussions: Reply directly to Sourcery's review comments.
    • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
    • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
    • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
    • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
    • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
    • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

    Customizing Your Experience

    Access your dashboard to:

    • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
    • Change the review language.
    • Add, remove or edit custom review instructions.
    • Adjust other review settings.

    Getting Help

    • Contact our support team for questions or feedback.
    • Visit our documentation for detailed guides and information.
    • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

    sourcery-ai[bot] avatar Sep 25 '25 11:09 sourcery-ai[bot]