FritzAndFriends
Unit tests needed
We need to start testing and ensuring the API continues to work properly
@csharpfritz do you have any preference for UnitTest framework? Mocking framework or DI for this? Do you want to keep it vanilla .net core or are you open to other options?
I like xunit and Moq.
I don’t think a DI Framework is needed.
What other options do you have in mind?
Jeff
On Jan 21, 2019, at 17:44, Simon Geering [email protected] wrote:
@csharpfritz do you have any preference for UnitTest framework? Mocking framework or DI for this? Do you want to keep it vanilla .net core or are you open to other options?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
I didn't have anything specific in mind, rather I'm happy to go with whatever you feel like using just didn't know what you were thinking. I'll have a play and see where I get, though I'm happy if someone else wants to jump in on this ahead of me.
I have managed to get an initial stab at a unit test project into the solution with XUnit, Moq and FluentAssertions but since it is now silly o'clock in the morning here in the UK, and my forked branch is behind FritzAndFriends, a PR will have to wait until tomorrow when I have time to pull changes integrate and re-test a build. The commit that will form the PR is here if you wanted a look before then 3433f53
@csharpfritz Any objections to an additional two references in the test project?
- A PackageReference to the NuGet package https://www.nuget.org/packages/coverlet.msbuild/
- A DotNetCliToolReference to https://www.nuget.org/packages/dotnet-reportgenerator-cli/
These combined will give us cross-platform support for code coverage statistics creation and reporting which will work from both VSCode and later be something we can hook into as part of the CI pipeline from the dotnet CLI
Sounds fine to me
Jeff
On Jan 22, 2019, at 15:47, Simon Geering [email protected] wrote:
@csharpfritz Any objections to an additional two references in the test project?
A PackageReference to the NuGet package https://www.nuget.org/packages/coverlet.msbuild/ A DotNetCliToolReference to https://www.nuget.org/packages/dotnet-reportgenerator-cli/ These combined will give us cross-platform support for code coverage statistics creation and reporting which will work from both VSCode and later be something we can hook into as part of the CI pipeline from the dotnet CLI
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.