laravel-vouchers icon indicating copy to clipboard operation
laravel-vouchers copied to clipboard

Roadmap

Open FrittenKeeZ opened this issue 5 years ago • 15 comments

0.1.x - 0.2.0

  • [x] Check morph map support
  • [x] Trigger notice on deprecated methods
  • [x] Add owner morph field
  • [x] Make migration command for owner field
  • [x] Add upgrade guide for owner field
  • [x] Remove deprecated methods
  • [x] Add changelog
  • [x] Add support for Laravel 8
  • [x] Prefix compiler optimized functions with \
  • [x] Use strict types where possible
  • [x] Add support for PHP 8

>0.2.x

  • [x] Add callback to Vouchers::redeemable() for conditional checks
  • [x] Remove migration command for owner
  • [ ] Change namespace from FrittenKeeZ to Frebs
  • [x] Remove support for PHP 7.1 and 7.2 (maybe 7.3 as well)
  • [x] Add without scopes
  • [x] Switch to Github Actions from Travis
  • [ ] Add documentation for vouchers with fixed codes like FREEBIE2021
    • withCode
    • withCounter
    • withCounterStep
    • withCounterSeparator
    • withCounterPadding
    • withCodeFormatter
  • [ ] Add unredeem() and unredeemable() helper methods
  • [x] Add primary key to all tables
  • [x] Make all migrations publishable
  • [x] Add support for Laravel 10
  • [x] Remove support for Laravel 5.x
  • [x] Remove support for PHPUnit 7/8
  • [x] Replace PHP CS Fixer with Laravel Pint
  • [ ] Refactor withEntities and addEntities to allow an array or Collection
  • [ ] Refactor withStartTime and withExpireTime to allow null

>1.x

  • [x] Remove support for PHP 7.x
  • [x] Remove support for Laravel 6/7
  • [x] Update PHPUnit configuration
  • [x] Replace unit tests with PEST

FrittenKeeZ avatar Aug 19 '20 07:08 FrittenKeeZ

Change namespace from FrittenKeeZ to Frebs

@FrittenKeeZ I do think this is a bad idea, do you have any specific reasons why you would want to change the Namespace to this???

I believe this should only happen if you decide to move the repository to another entity called Frebs. Let's have a conversation around this and know how this could affect current users. I believe it should be removed from the Roadmap.

zaghadon avatar Aug 28 '22 16:08 zaghadon

Change namespace from FrittenKeeZ to Frebs

@FrittenKeeZ I do think this is a bad idea, do you have any specific reasons why you would want to change the Namespace to this???

I believe this should only happen if you decide to move the repository to another entity called Frebs. Let's have a conversation around this and know how this could affect current users. I believe it should be removed from the Roadmap.

Only that it's shorter and simpler - regardless it would be a breaking change and a major dev version if I do, but I'm aiming to do it for 1.0.0

FrittenKeeZ avatar Aug 29 '22 07:08 FrittenKeeZ

Shorter and Simpler isn't a great reason for changing the namespace 😄.

Are you also changing your Username and Namespace across your other packages to frebs?🤔

zaghadon avatar Aug 29 '22 07:08 zaghadon

Shorter and Simpler isn't a great reason for changing the namespace 😄.

Are you also changing your Username and Namespace across your other packages to frebs?🤔

I don't really have any other noteworthy packages, but I would change the namespace across the board, yes.

FrittenKeeZ avatar Aug 29 '22 07:08 FrittenKeeZ

Ohh, okay. That's justifiable.

Hopefully this would be effectively documented. Let me know when you want to make this change so I could help implement and document it.

zaghadon avatar Aug 29 '22 08:08 zaghadon

@FrittenKeeZ Are you still working on open tasks ?

mgamal92 avatar Feb 14 '23 07:02 mgamal92

@mgamal92 I want to get back and update this for Laravel 10 and probably remove Laravel 5 in the process - there's been a lot of other projects taking my time, but I want to progress this one soon, and Laravel 10 is a good excuse :)

FrittenKeeZ avatar Feb 14 '23 08:02 FrittenKeeZ

@FrittenKeeZ May I help you in this package and work on some tasks ? so we can arrange that between us

mgamal92 avatar Feb 14 '23 08:02 mgamal92

@mgamal92 Sure, just open a PR

FrittenKeeZ avatar Feb 14 '23 08:02 FrittenKeeZ

@FrittenKeeZ Sure but are there some tasks which have more priority ?

mgamal92 avatar Feb 14 '23 08:02 mgamal92

@mgamal92 I've just updated the roadmap, but you can just choose what you feel like

FrittenKeeZ avatar Feb 14 '23 08:02 FrittenKeeZ

@FrittenKeeZ OK great

mgamal92 avatar Feb 14 '23 08:02 mgamal92

I would consider changing the "withEntities" to take a collection or array of entities. This would make it much easier to use programmatically, when you chain the facade.

Also it would be great if the withStartTime would take a null as well, so you do not have to wrap it in a if sentence first to make sure it exists, if you are generating these from some user input. Same with withEndTime.

addgod avatar Mar 07 '23 09:03 addgod

Will there be an update to support the latest Laravel framework e.g. 11.10.0?

jn-devops avatar Jun 11 '24 22:06 jn-devops

@jn-devops yes, I've thought about removing support for everything below Laravel 9 and update tests accordingly

FrittenKeeZ avatar Jun 12 '24 07:06 FrittenKeeZ