UncertaintyQuantification.jl icon indicating copy to clipboard operation
UncertaintyQuantification.jl copied to clipboard

update slurm_extras

Open yyimingucl opened this issue 1 year ago • 2 comments

add slurm_extras arguments to the HPC SlurmInterface for accepting some undefined slurm arguments.

yyimingucl avatar Mar 20 '24 15:03 yyimingucl

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.62%. Comparing base (730a718) to head (aed88ec).

Files Patch % Lines
src/hpc/slurm.jl 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   97.96%   90.62%   -7.35%     
==========================================
  Files          28       27       -1     
  Lines        1133     1088      -45     
==========================================
- Hits         1110      986     -124     
- Misses         23      102      +79     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 21 '24 16:03 codecov[bot]

Thanks for the PR @yyimingucl . What are the exact arguments currently missing that you need?

I see a small risk of conflicting options with defining them like this.

FriesischScott avatar Jul 19 '24 12:07 FriesischScott