tt_address icon indicating copy to clipboard operation
tt_address copied to clipboard

overrideFlexformSettingsIfEmpty does not work for hidePagination

Open lisardo2 opened this issue 3 years ago • 2 comments

in function override this code should override the settings from the flexform:

if (((!isset($previousData[$fieldName]) || (string)$previousData[$fieldName] === '') || (strlen($previousData[$fieldName]) === 0)) && isset($tsData['settings'][$fieldName]) ) {

hidePagination from the flexform is either 0 or 1 - never empty and never with strlen === 0. So this term above could not become true and therfore it is now impossible to override hidePagination

lisardo2 avatar Apr 06 '21 16:04 lisardo2

Seems to be similar to #421.

@responseinformationsdesign wanna do a PR?

georgringer avatar Jan 20 '23 06:01 georgringer