extension_builder icon indicating copy to clipboard operation
extension_builder copied to clipboard

Renew SPLIT_TOKEN

Open SSFGizmo opened this issue 1 year ago • 4 comments

Can SPLIT_TOKEN be renewed in // EXTENSION BUILDER DEFAULTS END TOKEN ..., because the PHP-CS-Fixer with the default configuration constantly changes it to //# EXTENSION BUILDER DEFAULTS END TOKEN ...?

SSFGizmo avatar Apr 03 '24 14:04 SSFGizmo

Actually it'S defined differently, but // is probably better than ## https://github.com/FriendsOfTYPO3/extension_builder/blob/db6794dc28fb074d4dbd80b27b028c90ed0f0006/Classes/Service/RoundTrip.php#L47

Problem might be in yaml files perhaps, I don't know if comments are possible there with //

Whats you suggestion and reasoning?

DavidBruchmann avatar Apr 03 '24 15:04 DavidBruchmann

In PHP files some comments starting with # might be mistaken as annotation and lead to errors therefore. It depends on the context though.

DavidBruchmann avatar Apr 03 '24 15:04 DavidBruchmann

@PKuhlmay you think we can just change the token? Or we need to take care about compatibility to former created extensions somehow? I think the token could be used in yaml files too, is this compatible?

DavidBruchmann avatar Apr 04 '24 17:04 DavidBruchmann

I don't know, honestly. We could change it and then test it with old extensions.

PKuhlmay avatar Apr 04 '24 17:04 PKuhlmay