symfony1 icon indicating copy to clipboard operation
symfony1 copied to clipboard

PHP 7.3 Support

Open charmoller opened this issue 4 years ago • 7 comments

Does this fork of symfony1 support PHP 7.3? Now that PHP 7.2 is out of support we are planning to upgrade our Symfony 1.4 application to PHP 7.3 and are investigating options.

charmoller avatar Dec 23 '20 03:12 charmoller

I use this fork with PHP7.4 without any problem.

ingcarlosperez avatar Dec 23 '20 03:12 ingcarlosperez

ditto, works fine with PHP 7.4 as well.

DavidGoodwin avatar Apr 08 '21 20:04 DavidGoodwin

Working for us with PHP 7.4 as well. Think this issue can be closed.

thirsch avatar May 26 '21 14:05 thirsch

Semi-tangent: for those running it with PHP 7.4, are you using propel1 (sfPropelORMPlugin) with it? Is that working well with PHP 7.4?

mentalstring avatar May 26 '21 15:05 mentalstring

Semi-tangent: for those running it with PHP 7.4, are you using propel1 (sfPropelORMPlugin) with it? Is that working well with PHP 7.4?

We are using Doctrine, sorry. There are a few git repos around for Propel 1.7 with PHP 7.4 support ... but perhaps that's the wrong version of Propel for symfony?

DavidGoodwin avatar May 26 '21 15:05 DavidGoodwin

but perhaps that's the wrong version of Propel for symfony?

I'm afraid that that is the only one with existing symfony1 integration (admin generator, crud, forms, etc) through sfPropelORMPlugin.

mentalstring avatar May 27 '21 17:05 mentalstring

Semi-tangent: for those running it with PHP 7.4, are you using propel1 (sfPropelORMPlugin) with it? Is that working well with PHP 7.4?

We at @prezly are maintaining our own forks of symfony1, propel1 and propel-orm-plugin to fix bugs and compatibility issues. AFAIK propel-orm-plugin works well with PHP up to 7.4. However, we had to apply a bunch of fixes to Propel1 in order to make it work on PHP 7.4 without throwing warnings:

  • https://github.com/rock-symphony/propel-orm/pull/3
  • https://github.com/rock-symphony/propel-orm/pull/5
  • https://github.com/rock-symphony/propel-orm/pull/7
  • https://github.com/rock-symphony/propel-orm/pull/18

e1himself avatar May 31 '21 12:05 e1himself