FOSFacebookBundle icon indicating copy to clipboard operation
FOSFacebookBundle copied to clipboard

Added integration of existing account.

Open daFish opened this issue 13 years ago • 8 comments

Fixes #145

daFish avatar May 23 '12 06:05 daFish

Looks like I screwed the PR. Maybe my commit (a369a1d) can be cherry picked.

daFish avatar May 23 '12 07:05 daFish

It would be nice to add the feature of merging a logged account with a facebook account instead of just checking the same email, because someone can use different emails

alex88 avatar Nov 05 '12 13:11 alex88

@alex88 this is the readme. Your code can modify this example in the way you want to implement more complex use cases.

stof avatar Nov 05 '12 18:11 stof

@stof which readme? I just given an advice in something else to add as feature.

alex88 avatar Nov 06 '12 09:11 alex88

@alex88 The whole description of storing users in the database when using this bundle, both in the current state of the bundle and in this PR. FOSFacebookBundle does not provide any sort of user persistence, so why should it try to implement the merging of a user with a persistent one (which is not implemented) ?

stof avatar Nov 06 '12 19:11 stof

So this pull request has no sense since it relies on persistent users?

alex88 avatar Nov 07 '12 14:11 alex88

@alex88 This PR does not rely on anything. It improves the README showing you how you can persist users. But it is only an example. Each project can adapt it to their own needs.

stof avatar Nov 07 '12 18:11 stof

Oh, sorry for that!

alex88 avatar Nov 08 '12 08:11 alex88