SyliusImportExportPlugin icon indicating copy to clipboard operation
SyliusImportExportPlugin copied to clipboard

Move import form to separate page

Open tautelis opened this issue 6 years ago • 1 comments

Q A
Bug fix? no
New feature? yes
BC breaks? yes in UI, no in CLI
Fixed tickets #208 #71

Main goal of this PR:

  • move import form to separate import page so the index page is not cluttered

Improvements:

  • having import button in top is intuitive when coming from other e-commerce platforms
  • most of the import form data validation is moved from Controller to ImportType
  • JS script added to display the name of the selected file for upload
  • since this will be a distributable package import route was prefixed with fos_sylius_import_export_ to avoid clashing with any project level routes prefixed with app_
  • importer tag types replaced with full sylius resource name same as exporter tags to keep the consistency and avoid sylius resource name ambiguity

UI import before: index-page-before

UI import after: index-page-after

import-page

tautelis avatar Nov 11 '19 00:11 tautelis

well, the rule of thumb is if you keep the PR open for too long the conflicts appear... why are we waiting this much? is there any problem with this PR? Things like this demotivates to contribute to open source projects.

tautelis avatar Jul 10 '20 12:07 tautelis