refactor ResourceImporter/ResourceExporter to be less dependent on portphp

Open lsmith77 opened this issue 7 years ago • 1 comments

Right now ResourceImporter and ResourceExporter is heavily bound to portphp which means that in the JSON importer/exporter we do not call the parent constructor which is a code smell: https://github.com/FriendsOfSylius/SyliusImportExportPlugin/blob/master/src/Importer/JsonResourceImporter.php#L10 https://github.com/FriendsOfSylius/SyliusImportExportPlugin/blob/master/src/Exporter/JsonResourceExporter.php#L26

phpstan complaints about this and so we have to add an ignore https://github.com/FriendsOfSylius/SyliusImportExportPlugin/blob/master/phpstan.neon

Jun 22 '18 13:06 lsmith77

relates also to https://github.com/FriendsOfSylius/SyliusImportExportPlugin/issues/51

Jun 26 '18 07:06 lsmith77