platform-plugin-dev-docker icon indicating copy to clipboard operation
platform-plugin-dev-docker copied to clipboard

Draft: task: add script to generate a GHA matrix

Open cngJo opened this issue 2 years ago • 6 comments

First version. Can currently only generate a GHA Matrix.

Open points:

  • how to exclude certain PHP versions for shopware versions? Can we just hard-code the Version steps?

Fixes #14

cngJo avatar May 23 '23 11:05 cngJo

Only missing part seems now the GHA changes. JS looks good :)

shyim avatar May 25 '23 15:05 shyim

Yes, but also the use of the new static-data from https://github.com/FriendsOfShopware/shopware-static-data/pull/1 needs to be integrated.

I already have a version for that locally, I'm currently testing.

cngJo avatar May 25 '23 16:05 cngJo

Also, https://github.com/FriendsOfShopware/shopware-static-data/pull/2 needs to be merged for this, since the code in did not respect minified responses from the Packagist API which.

cngJo avatar May 25 '23 17:05 cngJo

First of all, thanks a lot. I will go through the changes the next days :-)

aragon999 avatar May 30 '23 17:05 aragon999

Thanks! I've run into issue when the current matrix would exceed the max amount of Matrix Runners you can start, so I started working on an option that would allow you to build the matrix by major version.

This worked for 6.5, but not for 6.4 since, we there are still over the limit. We might need to adapt the logic to generate the matrix by major.minor.

But if we decide to split it up further, we need to find a proper solution for the hard coded versions like trunk. Maybe just throw it into a JSON file in the repo, and/or add an option to specify hard-coded as a version to the bin/generate-matrix.js script.

cngJo avatar May 30 '23 18:05 cngJo

We could also stop generating for versions older than (f.e.) two years. This would mean, we would not generate anything for <6.4.4.0

tinect avatar Sep 04 '23 10:09 tinect