FriendsOfPHP
Data in application/x-www-form-urlencoded format from github isn't handled
Currently only JSON data is accepted from github, supporting application/x-www-form-urlencoded might be subject of the further refactoring/extending.
Hm?
In which context? Hook? Auth?
We may add the right header. Also the builtin server is bad at handling json data or other mime types. On May 8, 2015 6:40 PM, "Anatol Belski" [email protected] wrote:
Currently only JSON data is accepted from github, supporting application/x-www-form-urlencoded might be subject of the further refactoring/extending.
— Reply to this email directly or view it on GitHub https://github.com/FriendsOfPHP/pickleweb/issues/38.
Still talking about the hooks, as after figuring out the cause of #37 i was just trying to misconfigure as much as i could. But this could be done abstracting the data parsing into some layer according to their type. So I wanted just to note it could/should be done somewhen :)
Does it work once configured correctly?
This is the main thing, every thing else can wait.
We can a short sanity check in the github controller and bailout with a message saying that this event is not supported. But that's all we need for now. On May 8, 2015 6:55 PM, "Anatol Belski" [email protected] wrote:
Still talking about the hooks, as after figuring out the cause of #37 https://github.com/FriendsOfPHP/pickleweb/issues/37 i was just trying to misconfigure as much as i could. But this could be done abstracting the data parsing into some layer according to their type. So I wanted just to note it could/should be done somewhen :)
— Reply to this email directly or view it on GitHub https://github.com/FriendsOfPHP/pickleweb/issues/38#issuecomment-100209458 .
Yep, when application/json selected and it works. When documented, it's should be fine at the current stage.
Woohoo :) On May 8, 2015 7:11 PM, "Anatol Belski" [email protected] wrote:
Yep, when application/json selected and it works. When documented, it's should be fine at the current stage.
— Reply to this email directly or view it on GitHub https://github.com/FriendsOfPHP/pickleweb/issues/38#issuecomment-100213128 .
@anatol
Can you be more precised in the wiki? Create/delete tag, and release
Also I have to fix the API key and link part, it is easier now, one click and you get it from the extension page. On May 8, 2015 7:18 PM, "Pierre Joye" [email protected] wrote:
Woohoo :) On May 8, 2015 7:11 PM, "Anatol Belski" [email protected] wrote:
Yep, when application/json selected and it works. When documented, it's should be fine at the current stage.
— Reply to this email directly or view it on GitHub https://github.com/FriendsOfPHP/pickleweb/issues/38#issuecomment-100213128 .
But that's exactly what stands there on the hook settings page, against the checkbox:
Create Branch, or tag created.
Exactly one word against checkbox, so hard to mix up.
Branch is bailed out by pickleweb, just tested and it works.
Yes, but the word "tag" is missing in the wiki :) On May 8, 2015 7:35 PM, "Anatol Belski" [email protected] wrote:
But that's exactly what stands there on the hook settings page, against the checkbox:
Create Branch, or tag created.
Exactly one word against checkbox, so hard to mix up.
Branch is bailed out by pickleweb, just tested and it works.
— Reply to this email directly or view it on GitHub https://github.com/FriendsOfPHP/pickleweb/issues/38#issuecomment-100219179 .