galaxy-integration-steam icon indicating copy to clipboard operation
galaxy-integration-steam copied to clipboard

Published 20 hours ago • verified publisher icon FriendsOfGalaxy

No achievement load when there is many of them

Open Danyelalejandro opened this issue 5 years ago • 19 comments

Describe the bug Once GOGgalaxy 2.0 is started, Steam plugin starts to crash after a few minutes.

To Reproduce Steps to reproduce the behavior

  1. Log in with account that have almost 2k games
  2. Wait 2 minutes
  3. Plugin has crashed
  4. Click on "Retry"
  5. Wait 2 minutes
  6. Plugin crashed again
  7. Steps 5 and 6 repeats indefinitely

Expected behavior Plugin should not crash.

Attached logs plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip

Danyelalejandro avatar Dec 18 '19 01:12 Danyelalejandro

Hey @Danyelalejandro does the issue still reproduce?

FriendsOfGalaxy avatar Jan 10 '20 15:01 FriendsOfGalaxy

Hello @FriendsOfGalaxy Yes, it still does. furthermore, when it connects does not load achievement data. My Steam profile has 2015 games and 470,511 achievements. I still suspect that plugin or client cannot handle all this data.

Danyelalejandro avatar Jan 11 '20 00:01 Danyelalejandro

This is what reports when I try to share my data: image

Danyelalejandro avatar Jan 11 '20 00:01 Danyelalejandro

Hey, since the plugin content has changed in last versions, please send us logs once again. Zip all logs with extensions log. log1-10 for steam plugin and GalaxyClient a few minutes after a crash

FriendsOfGalaxy avatar Jan 13 '20 08:01 FriendsOfGalaxy

Hello @FriendsOfGalaxy Sorry to have so many bugs. I hope this could help to improve the beta. I will give an update of What´s going on with my case:

  1. Client does not open with Windows anymore. I have to open manually and do several tries
  2. Crashes of plugin are less frequent but still happens
  3. It never load the total amount of my achievements. Steam reports 470,511 but it goes up to 322.166 as maximum when it loads. Sometimes achievements are not loaded.
  4. On the "Recent" page it stays stuck in "loading" or "Sorry, we couldn't load the data. Retry!
  5. Share stats button doesn't work properly. It does not report achievements or, nothing at all, just a "bad request" page I will attach new logs, hopefully they can help. If you think I should open this bug or to report something else, just let me know. Thank you so much plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip

Danyelalejandro avatar Jan 15 '20 04:01 Danyelalejandro

Hello guys,

Today, it showed briefly most of the achievements, but it didn't last so much. I was unable to share it.

Attached you will find new logs:

plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip

Danyelalejandro avatar Jan 19 '20 04:01 Danyelalejandro

Hello guys,

New update. Hoping this could help to improve plugin, beta and the experience for users:

  1. Crashes are less frequent. Just one at week. We could say this is tolerable. Nevertheless, this doesn't happen with another plugins
  2. Still having problems loading data from games or recent tab. Load times take so much. Sometimes game information is not shown.
  3. Today, I was able to see all real data in the Recent tab for first time: image Nevertheless, recent tab stuck on "loading" again.
  4. I tried to share it in the button: "share stats" this is the result: image
  5. After a few minutes I tried again. This is the result: image
  6. Third try: image Right now Recent tab is stuck on loading, and data of some games is loaded and some not.

I am not sure, maybe speculating, but I think Plugin or Client are not able to handle all the data my Steam profile has. I have seen profiles with more games than I do and they didn't have report similar issues. It could be related to achievement data. It is not possible to keep some Steam plugin information in cache? in the PC? to download it so it will not need to load it from some server once and once again?

I will attach new logs. I hope they could be useful. plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip

Danyelalejandro avatar Jan 22 '20 00:01 Danyelalejandro

@Danyelalejandro Thanks for details. I'm investigating this problem.

FriendsOfGalaxy avatar Jan 22 '20 09:01 FriendsOfGalaxy

@Danyelalejandro does the problem still occurs? The code has changed many times since your report

FriendsOfGalaxy avatar Jul 01 '20 10:07 FriendsOfGalaxy

plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip Hello, Crashes are less frequent, but still happens. Once or Twice at day. Don´t know yet if this is related to the great amount of achievements I have. Thank you so much.

Danyelalejandro avatar Jul 01 '20 15:07 Danyelalejandro

@Danyelalejandro thanks. Please attach attach also logs from Galaxy

  • GalaxyClient.log 01, 02, ... .10 ect. as well
  • plugin logs as usual Attach both in one zip no longer than after 2 hours after last crash - I need to compare Galaxy and plugin calls.

You have so many achievements that that they takes like 15MB in logs:)

FriendsOfGalaxy avatar Jul 03 '20 10:07 FriendsOfGalaxy

GalaxyClient.log.zip Oh no, I imagine that would be an issue. Too bad... Hope this could help to others. Thanks plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip

Danyelalejandro avatar Jul 03 '20 18:07 Danyelalejandro

@Danyelalejandro please try out this build:

steam - probable fix for blocking games and less logs.zip (assuming you're on windows...)

  • Close Galaxy
  • remove old plugin from %localappdata%\GOG.com\Galaxy\plugins\installed
  • extract zip to the same place

I read all your logs again but its still hard to say what had happen. If the plugin still crashes, please attach all steam logs along with GalaxyClient logs. Those combination is most valuable for me. And the best is when you zip logs just before restarting steam plugin or Galaxy.

Thanks!

FriendsOfGalaxy avatar Aug 17 '20 16:08 FriendsOfGalaxy

Hello @FriendsOfGalaxy Installed already, general performance is better, but achievements are not yet complete. plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip I think I have to made peace with this. Achievements was a plus but not the most important part of the integration. Hoping it could be fixed someday Attached you will find shared stats. Not all achievements are reported, but all games and hour played yes. image

I will send you regularly logs. Thanks a lot

Danyelalejandro avatar Aug 18 '20 17:08 Danyelalejandro

Thanks for testing! Good to know that it helped somehow.

Please replace file /galaxy/api/json.rpc with this one: jsonrpc.zip

The change is to log number of achievements per game instead of all achivements there. This would greatly reduce amount of logs in your case and allow for better logs inspection next time.

FriendsOfGalaxy avatar Aug 19 '20 09:08 FriendsOfGalaxy

Hello dear @FriendsOfGalaxy Achievements number has not showed any change since I installed jsonrpc file. I will attach new logs

Kind Regards, plugin-steam-ca27391f-2675-49b1-92c0-896d43afa4f8.log.zip

Danyelalejandro avatar Aug 19 '20 23:08 Danyelalejandro

Hello @Danyelalejandro, I see the plugin properly send all achievements. Some of your games have 5000 achievements. I need to verify if Galaxy has problem with handling those at once or problem with handling all games achievements at once.

I need to buy some dummy "achievements-producer" games and check it myself

FriendsOfGalaxy avatar Aug 28 '20 09:08 FriendsOfGalaxy

Thank you @FriendsOfGalaxy usually those games could cost 0.50 USD or less in promotions. If you need more logs, just let me know.

Danyelalejandro avatar Aug 28 '20 14:08 Danyelalejandro

With only one game like this (5k achievements unlocked) there is no repro for me. Maybe I should buy more.

FriendsOfGalaxy avatar Apr 14 '21 08:04 FriendsOfGalaxy