mason icon indicating copy to clipboard operation
mason copied to clipboard

When mason fields are in Banner, DiscussionPage-nav not showing properly

Open prestorondo opened this issue 7 years ago • 4 comments

If you choose "Show fields in the discussion banner instead of the "first post" , in any discussion page, the right navigator will not render properly .(~~because of it's <ul> has position:fixed , a quick change to position:absolute would fix the problem~~* )

I do not know whether this issue is related to flarum/core or this extension.

  • I realised shortly after I changed that the behaviour changes (the nav isn't sticky anymore which is not cool 😢 ) if we do this, please ignore this fix.

prestorondo avatar May 08 '18 11:05 prestorondo

Can you post a screenshot perhaps?

luceos avatar May 08 '18 13:05 luceos

mason-hero

if I am on my big monitor, I do not have that problem but on tablet I still see it.

prestorondo avatar May 08 '18 13:05 prestorondo

I'm in doubt, I'd say this is a core issue. What do you think @clarkwinkelmann ?

luceos avatar May 08 '18 13:05 luceos

Yes I'm also blaming core :joy: The sidebar simply stays where it was at page load. Which is fine with the default design, less fine when you add stuff to the header.

Not sure how easy to fix it is (in core) though. Depends what library is responsible for that affix effect and whether there's an option to more it higher when scrolling...

clarkwinkelmann avatar May 08 '18 16:05 clarkwinkelmann