bootstrap-ui icon indicating copy to clipboard operation
bootstrap-ui copied to clipboard

1.4 horizontal form issues

Open burzum opened this issue 5 years ago • 0 comments

This is a (multiple allowed):

  • [x] bug

  • [ ] enhancement

  • [ ] feature-discussion (RFC)

  • BootstrapUI Version: 1.4

What you did

Updated from 0.3 to 1.4.

image image

Expected Behavior

That the horizontal form text inputs display as before.

image image

See the Bootstrap docs as well https://getbootstrap.com/docs/3.4/css/#forms-inline

<form class="form-inline">
  <div class="form-group">
    <label for="exampleInputName2">Name</label>
    <input type="text" class="form-control" id="exampleInputName2" placeholder="Jane Doe">
  </div>
  <div class="form-group">
    <label for="exampleInputEmail2">Email</label>
    <input type="email" class="form-control" id="exampleInputEmail2" placeholder="[email protected]">
  </div>
  <button type="submit" class="btn btn-default">Send invitation</button>
</form>

Actual Behavior

They're missing the div container. Also something is wrong with the labels, I've just noticed this.

The cause of the problem is this commit. When I revert it everything is fine:

https://github.com/FriendsOfCake/bootstrap-ui/commit/2b5a2291e7bba8efbec178514147cba6564ff8cb#diff-86d5537968f770710b98fddb2840fcda

burzum avatar Jan 13 '20 13:01 burzum