friendly-lite-server icon indicating copy to clipboard operation
friendly-lite-server copied to clipboard

Swap `SECRET` and `API_KEY` ?

Open wi-wissen opened this issue 2 years ago • 2 comments

I don't know if it's just me, but from my point of view SECRET and API_KEY are used against the other convention.

Currently, you define SECRET, which you use as the sitekey in the widget. And when checking, the result the API_KEY is the parameter secret but then SECRET is the parameter sitekey.

Wouldn't it make sense to swap the variables in the lite server?

wi-wissen avatar Feb 21 '23 22:02 wi-wissen

I think you are right. We could also just call it SITEKEY and so on

amenk avatar Jul 02 '23 09:07 amenk

Yes, fwiw I found the naming of the parameters/constants confusing as well :-)

lhaemmerle avatar Jan 12 '24 10:01 lhaemmerle