talker icon indicating copy to clipboard operation
talker copied to clipboard

Add Custom Settings Bottom Sheet without needing existing code changes

Open wolfe719 opened this issue 1 year ago • 2 comments

Add method for interested individuals to create custom settings bottom sheets.

This method does not require any code changes to existing projects.

An optional argument is added to the TalkerScreen() function, a settingsBottomSheetCreator function.

If set, the settingsBottomSheetCreator function is called to create a custom Bottom Sheet for settings.

An example project using this method is created - the sample custom settings BottomSheet creator has the three existing basic settings (Enabled, Use console logs, Use history), and adds two more:

  • Custom Bool that is enabled/disabled based upon the "Enabled" setting
  • Global Custom Bool that can be enabled/disabled without regard to the "Enabled" setting

wolfe719 avatar Oct 11 '24 17:10 wolfe719

Hello @wolfe719 ! Thank you for your contribution! ❤️ I have noticed a lot of changes. I will review it and provide feedback soon.

Frezyx avatar Nov 12 '24 18:11 Frezyx

Updated to remove conflicts with base branch. Just want to make your review that much easier.

Note that I moved your example app down one directory level, and added a second sample app, this one with a custom settings view. So now you have two example apps:

examples/shop_app - used to be shop_app_example examples/shop_app_with_custom_settings - new example app demonstrating use of custom settings view

wolfe719 avatar Dec 09 '24 14:12 wolfe719