Patrick Schmidt

No final opinion, just some quick gut reactions: - Regular and disabled doesn't use two different font colors for selected/unselected. So I think it would be wierd for read-only to...

> There is a discussion to be had when there are security annotations on both the layout class and view class. Should the view override the layout? Vice-versa? Should they...

`setMaxFiles(0)` actually disables the component, so that can be used as a workaround. But unlike with other components, setting the containing layout disabled will not propagate to `Upload`.

To make it short, in a Spring Boot application, Vaadin uploads between 1MB and 10MB will fail. Above and below that will work. To fix or at least work around...

You are right that an unused value could also mean that the value still needs to be used. But that's something that should also come up during testing, if not...

I created this ticket assuming that `UnusedAssignment` would one day replace `UnusedLocalVariable` and `UnusedFormalParameter` (with `reportUnusedVariables` = true), based on that one sentence from the documentation: `The rule subsumes UnusedLocalVariable,...

Considering this plug-in is about sorting imports I was surprised it even touched the lines _around_ the imports at all. I expected it to rearrange imports between the line of...

I'm in a similar situation where I need to treat the default language differently because its URL diverges from the pattern of non-default languages. Markdown links are adapted automatically but...

Okay, that explains the blank page, instead of an error, which Vaadin 24 seems to fix. But why does my Summernote integration work in dev mode, but not in production...

That's weird. I just tried it again with a fresh checkout and from within Eclipse the projects runs without errors: