FreshRSS icon indicating copy to clipboard operation
FreshRSS copied to clipboard

[Feature] Move logout button to the end of list

Open ketozhang opened this issue 2 years ago • 11 comments

Is your feature request related to a problem? Please describe. I’m always frustrated1 when I click the gear icon and accidentally log out. I also accidentally clicked logout from the settings page.

[1]: I love how the issue template started my sentence

Describe the solution you’d like Please move logout to the last item in settings. It is common practice, bet its part of some UX consensus---for example, github: image

ketozhang avatar Oct 22 '23 05:10 ketozhang

I'm inclined to agree. 👍

Frenzie avatar Oct 22 '23 07:10 Frenzie

Agreed. I too get logged out due to page getting aligned upon full load. Very frustrating.

vdbhb59 avatar Oct 22 '23 13:10 vdbhb59

Thanks for giving feedback so that we could improve the UX.

Before we discuss a solution let me understand the issue better.

Which theme do you use? Which FreshRSS version? Mobile or Desktop view? What exactly do you do? Could you please describe step by step your actions or could you please record it as video/GIF?

math-GH avatar Oct 22 '23 14:10 math-GH

Thanks for giving feedback so that we could improve the UX.

Before we discuss a solution let me understand the issue better.

Which theme do you use? Which FreshRSS version? Mobile or Desktop view? What exactly do you do? Could you please describe step by step your actions or could you please record it as video/GIF?

Responses below: Irrespective of the theme the logout button is at 2nd position 1.21.0 Mobile/Desktop - both For me happens mostly when loading a page and clicking on it in error upon trying to click on first instance It also happens when in error or by mistake the logout button gets clicked while trying to click some other button

vdbhb59 avatar Oct 22 '23 16:10 vdbhb59

Ditto to @vdbhb59 with the difference that I am use https://feeds.flossboxin.org.in (I am a fresh user just trying this out before self-hosting).

ketozhang avatar Oct 23 '23 20:10 ketozhang

Ditto to @vdbhb59 with the difference that I am use https://feeds.flossboxin.org.in (I am a fresh user just trying this out before self-hosting).

That is my instance only (I run it). So, similar issue. Though, I found it same on my personal host too on a different server.

vdbhb59 avatar Oct 23 '23 20:10 vdbhb59

I've never accidentally logged out but I can see how it's dangerously close to other things. But also, the position of close/logout everywhere else conditions us to look at the bottom.

Frenzie avatar Oct 23 '23 20:10 Frenzie

Hi @ketozhang , I would like to work on this issue.

HarikaB11 avatar Nov 24 '23 06:11 HarikaB11

Go ahead @ketozhang 👍🏻

Alkarex avatar Nov 24 '23 09:11 Alkarex

Please take a look at my commit here and if any changes let me know

If everything is okay I'll create a pull request

It's my first pull request so I appreciate all help

MananDhiman avatar Nov 26 '23 10:11 MananDhiman

@MananDhiman Just make a PR. It makes it easier to provide feedback, further edits, and tests

Alkarex avatar Nov 26 '23 15:11 Alkarex