FreshRSS
Clear cache while adding a new feed
Closes #3658
Changes proposed in this pull request:
- Remove cache feed when adding it
How to test the feature manually:
- Click on the bookmarklet to add a feed
- Do not save the new feed
- Click again on the bookmarket
Pull request checklist:
- [x] clear commit messages
- [x] code manually tested
- [ ] unit tests written (optional if too hard)
- [ ] documentation updated
Additional information can be found in the documentation.
Before, the feed cache was preventing to add a feed when using twice the bookmarklet if the first time the user aborted the process. Now, the cache is removed for the feed before loading information. This behavior as a limited impact since only the selected feed cache is removed.
@Alkarex This works well for the bookmarklet use-case. I don't know if it has side-effects though. Could you validate that I did not miss something? Thank you!
It also solves another very related bug if you add a feed from one user account, and immediately add it in another user account. There are several small cache issues like that, in particular when there are errors (error information is not persisted correctly).
It is not the proper fix, but that is probably better than what we have at the moment. Maybe we should add a TODO though
Hold on, I think this creates a new bug, when adding a feed using auto-discovery, deleting it, and adding it again (or add the same feed in two different users)
As I mentioned in the original issue, we might just add something in the documentation because it is an edge-case.
This is not completely trivial. When adding a feed with auto-discovery (i.e. provide https://example.net/ instead of https://example.net/rss.xml ), more than one cache file is created and apparently deleting only one creates other bugs. As this is not a regression, I suggest we release 1.18.1 very soon (e.g. latest this week-end if there is no other feedback) and come back to a proper cache improvement afterwards
any news?
I need to take some time to work on it, and it is not completely trivial. I would like to complete a couple of other work-in-progress PRs before