Extensions icon indicating copy to clipboard operation
Extensions copied to clipboard

Extension StickyFeed

Open Grishkaone opened this issue 3 years ago • 8 comments

Hello !

I've found a little bug in the Sticky Feeds extension. When using a web browser to access my FreshRSS installation, I can use Safari or Firefox :

Safari / extension off

In this configuration, the left bar (feeds tree) scrolls out of sight with the content.

https://user-images.githubusercontent.com/46840243/147943483-979b172f-5415-4eef-95de-57bef9086f70.mov

Safari / extension on

Here, the menu stay in place. I can scroll inside, or in the content on the right, independently.

https://user-images.githubusercontent.com/46840243/147943511-01351389-5335-4d48-803e-3e04829bd344.mov

Firefox / extension off

The menu stay in place, I can scroll both part independently.

https://user-images.githubusercontent.com/46840243/147943526-c2891991-e6ae-413b-b804-17ba06b01835.mov

Firefox / extension on

This is quite funny actually : when I scroll down on the content side, the feeds menu goes down out of screen entirely. 😂

https://user-images.githubusercontent.com/46840243/147943554-b75ee439-72ed-47ef-a485-45c9e9ec20f3.mov

So the 1) the behavior is not consistant between browser and extension status and 2) Firefox is going nuts when it's active. Any idea ?

🖖

Grishkaone avatar Jan 03 '22 14:01 Grishkaone

Pinging @marienfressinaud

Frenzie avatar Jan 03 '22 15:01 Frenzie

The StickyFeed is no longer necessary since it's natively supported by FRSS now (this is why it works on Firefox with the extension disabled). I suspect a bug in Safari, maybe this one? https://stackoverflow.com/questions/51792783/safari-positionsticky-not-working-in-an-overflowauto-element

I don't have Safari on my computer so I can't confirm.

marienfressinaud avatar Jan 03 '22 15:01 marienfressinaud

I can confirm, that in Safari the side navigation does not stick at the top as the Firefox does.

math-GH avatar Jan 03 '22 17:01 math-GH

You mean at all or with this extension enabled? Because if the latter, well, let's just remove it (probably leaving a deprecated & removed README in there for a while).

Frenzie avatar Jan 03 '22 17:01 Frenzie

I tested Safari without this extension.

Summary: Without extension: Firefox: Sidebar fixed while scrolling Safari: Sidebar does not fix while scrolling

math-GH avatar Jan 03 '22 17:01 math-GH

@math-GH Could you try to add position: -webkit-sticky;? (https://github.com/FreshRSS/FreshRSS/blob/edge/p/themes/base-theme/template.css#L246-L251)

marienfressinaud avatar Jan 03 '22 18:01 marienfressinaud

The -webkit- prefix is normaly not used by Safari 15. I tried with <nav>, the full .aside and .aside.aside_feed elements, even with the .treewithout any success. I also tried without the -webkit- prefix, same result. 😕

Grishkaone avatar Jan 03 '22 19:01 Grishkaone

Sorry, I have not seen the response. I do not have any Mac devices anymore to test it

math-GH avatar Jan 31 '24 18:01 math-GH