latest tag pulls pre-releases

[vordenken]

Describe the bug Using the "latest" tag also pulls pre-releases, not just releases.

To Reproduce Steps to reproduce the behavior:

1. Use tag latest to pull docker-image
2. check version
3. See pre-release version

Expected behavior latest should only pull final releases

[makanimike]

Perhaps it deserves its own thread, but I seem to be stuck in the nomansland between 'latest' and the pre-release?

I got the notification that dawarich (along with a handful other apps on my system) had updates. So I installed all of them. Then I got an error message about the entrypoint.sh file not being where it was expected. Only then did I read the release notes for 0.22.0 .
So, I made the two changes for entrypoint and command for the app and sidekiq. But now the app will not start up. The very non-descriptive error message simply says:
dependency failed to start: container dawarich_app is unhealthy

[narucx]

Perhaps it deserves its own thread, but I seem to be stuck in the nomansland between 'latest' and the pre-release?

I got the notification that dawarich (along with a handful other apps on my system) had updates. So I installed all of them. Then I got an error message about the entrypoint.sh file not being where it was expected. Only then did I read the release notes for 0.22.0 . So, I made the two changes for entrypoint and command for the app and sidekiq. But now the app will not start up. The very non-descriptive error message simply says: dependency failed to start: container dawarich_app is unhealthy

Its probably the gems stuff https://github.com/Freika/dawarich/releases/tag/0.22.1

[makanimike]

that fixed it. that was easy! (and obvious, I should have done it after the other modifications) thanks!

[J-shw]

So I belive the issue is because the GitHub workflow is set up to create a docker image on release, but that release is not specifically Pre-release or latest. So on any release, a new docker image is made.

on:
  workflow_dispatch:
    inputs:
      branch:
        description: "The branch to build the Docker image from"
        required: false
        default: "master"
  release:
    types: [created]

[J-shw]

So I did some research and think that by adding if: "!github.event.release.prerelease" it checks if the release is not a prerelease

Not sure how to test it.. But I hope its helpful!

[Freika]

Fixed in 0.22.4-rc