dawarich icon indicating copy to clipboard operation
dawarich copied to clipboard

Prevent schedule_visit_suggesting from throwing an error when no points are imported because they are already known

Open saschazepter opened this issue 1 year ago • 4 comments

…ts are imported because they are already known

saschazepter avatar Sep 26 '24 19:09 saschazepter

@saschazepter would you mind adding tests as well?

Freika avatar Sep 28 '24 14:09 Freika

@saschazepter would you mind adding tests as well?

Tested all my patches/pull request with my "live" installation. How do you wish tests to be documented?

For this case, you simply import a GPX file and import it a second time later on, where all points have already been imported the first time. So you will get the "strange" notification behaviour. I have mapped the patched file into the docker containers for testing and retested it with the same GPX file.

saschazepter avatar Sep 28 '24 17:09 saschazepter

OK ... got you. :-)

saschazepter avatar Sep 28 '24 17:09 saschazepter

Just in case, here is the file you can add tests to :) https://github.com/Freika/dawarich/blob/master/spec/services/google_maps/records_parser_spec.rb

Freika avatar Sep 28 '24 17:09 Freika