AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

Prevent multiple file pickers when loading logs (fixes #2363)

Open Bennethxyz opened this issue 1 month ago • 4 comments

This PR prevents multiple file picker dialogs from opening when holding Ctrl+Meta+L on the pre-match screen.

  • Introduces a throttled wrapper around the existing log file loader using underscore's throttle (same pattern used for saving logs in utility/gamelog.ts).
  • Keeps behavior identical otherwise; only one dialog can be triggered per second.
  • Adds minor safety checks for empty selection and types.

Tested locally by holding the hotkey; only a single chooser appears.

Fixes #2363.

Bennethxyz avatar Nov 03 '25 18:11 Bennethxyz

Someone is attempting to deploy a commit to the FreezingMoon Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 03 '25 18:11 vercel[bot]

Also addresses #2174 by flashing the cancel icon on unusable/used active ability clicks.

Bennethxyz avatar Nov 03 '25 18:11 Bennethxyz

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
ancientbeast Ready Ready Preview Nov 4, 2025 4:58am

vercel[bot] avatar Nov 04 '25 01:11 vercel[bot]

@Bennethxyz As I was saying in the other PR for this, can't currently reproduce the issue myself; will try different browsers and operating systems pretty soon. I like that you took a different approach altogether though.

Also addresses #2174 by flashing the cancel icon on unusable/used active ability clicks.

Regarding this one, wish it was a different PR altogether to keep things nicer. I've tested it and works fine overall, but found an issue: no cancel icon is displayed when clicking the passive ability after you materialize and unit with Dark Priest.

DreadKnight avatar Nov 04 '25 01:11 DreadKnight