AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

Added "Share Replay" Button, Icon, and Download Feature

Open yousefsassy opened this issue 9 months ago • 7 comments

Description

This fixes issue #1779.

This PR addresses Issue #1779 by adding a "Share Replay" button to the scoreboard screen. The changes include:

share.svg icon added to assets/interface/ for the button.

The ability for users to download match replay logs in JSON format.

The button’s size and alignment have been matched with the "Flee Match" button for consistency.

Changes made:

index.ejs: Implemented the "Share Replay" button and wired the functionality for exporting replay logs.

assets/interface: Added share.svg icon used for the button.

styles.less: Ensured the "Share Replay" button has the same size and positioning as the "Flee Match" button.

interface.js: Added logic to enable downloading of replay logs in JSON format when the "Share Replay" button is clicked.

Wallet address: 0x0000000000000000000000000000000000000000

yousefsassy avatar Mar 28 '25 17:03 yousefsassy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Mar 28, 2025 5:06pm

vercel[bot] avatar Mar 28 '25 17:03 vercel[bot]

@yousefsassy As indicated in the "contribution" guide, usually try not to poke at issues that have the "brainstorm" tag and/or are in a too far away milestone. This is pretty good, but will need a bit more work, will tweak original specs, contribute a bit to the PR myself and request a few more tweaks from you as well pretty soon 🐻👍🏻 Also, please update wallet address with proper one or don't include a bad one :D

DreadKnight avatar Mar 29 '25 10:03 DreadKnight

@yousefsassy

Heya! Looked more at this. Here's a list of glitches that would need fixing and things that could be improved:

  • new icon that reflects better the action - https://game-icons.net/1x1/delapouite/save-arrow.html
  • icon style consistency: transparent background and 4px black outline (doable from game-icons.net editor itself)
  • the icon shouldn't be moved to the left side a bit when the "restart match" is being hovered and showing a tooltip
  • the icon shouldn't zoom in a bit on hover in order to keep consistency
  • should have a tooltip and showcase hotkey in it (Ctrl+S) like the "restart match"

DreadKnight avatar Apr 22 '25 03:04 DreadKnight

@DreadKnight got it ! you told me that this issue has a brainstorm tag so its not recommended for me to poke at it since you replied to me about this issue, means that it doesnt belong to the brainstorm section anymore and can work on it ?

yousefsassy avatar Apr 22 '25 10:04 yousefsassy

@DreadKnight got it ! you told me that this issue has a brainstorm tag so its not recommended for me to poke at it since you replied to me about this issue, means that it doesnt belong to the brainstorm section anymore and can work on it ?

@yousefsassy Yeah, go for that list of to-do's. Once everything is checked, I will get this merged in.

DreadKnight avatar Apr 22 '25 10:04 DreadKnight

@yousefsassy Any progress with this one? It's starting to get conflicts...

DreadKnight avatar May 27 '25 07:05 DreadKnight

@yousefsassy Poke 🐻

DreadKnight avatar Jun 09 '25 18:06 DreadKnight