ability targeting matrice rename [bounty: 3 XTR]

[DreadKnight]

trafficstars

PR #2556 (related to #1696) moved one of Stomper's targeting matrice into a file containing more of those. The matrice should be named more generic, no unit/ability name but describing area rather. Matrice code: https://github.com/FreezingMoon/AncientBeast/blob/master/src/utility/matrices.ts#L230

[allmtz]

The origin lines for Earth Shaker and Infernal Prayer are slightly different:

// Earth Shaker
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[0, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

// Infernal Prayer
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[1, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

I tried using the Earth Shaker matrix for Infernal Prayer but this results in not being able to attack targets in the hex directly in front and behind of the Infernal. Pretty sure this is because an Infernal is 3 hexes wide vs Stomper being 2 hexes wide.

Both matrices are needed but they could be made more generic with names like largeCreatureFrontAndBack9Hex and mediumCreatureFrontAndBack8Hex. Or more specifically size2CreatureFrontAndBack8Hex and size3CreatureFrontAndBack9Hex. Not very pretty but it avoids confusion in the future if a creature larger than 3 hexes is introduced. @DreadKnight thoughts?

[DreadKnight]

The origin lines for Earth Shaker and Infernal Prayer are slightly different:

// Earth Shaker
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[0, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

// Infernal Prayer
	[
		[0, 0, 1, 0],
		[0, 0, 1, 1],
		[1, 1, 1, 0], // Origin line
		[0, 0, 1, 1],
		[0, 0, 1, 0],
	]

I tried using the Earth Shaker matrix for Infernal Prayer but this results in not being able to attack targets in the hex directly in front and behind of the Infernal. Pretty sure this is because an Infernal is 3 hexes wide vs Stomper being 2 hexes wide.

Both matrices are needed but they could be made more generic with names like largeCreatureFrontAndBack9Hex and mediumCreatureFrontAndBack8Hex. Or more specifically size2CreatureFrontAndBack8Hex and size3CreatureFrontAndBack9Hex. Not very pretty but it avoids confusion in the future if a creature larger than 3 hexes is introduced. @DreadKnight thoughts?

Thought there was an issue regarding reusing that, thanks for looking into it and confirming @allmtz I think the issue is not actually because of the different size of units, but that Intense Prayer affects a bigger area for several reasons:

• animation wise, Infernal will be hitting frontal-underneath hexagon
• upgraded Intense Prayer will be complementing the passive nicely if keeping position, leaving traps under all Infernal's hexagons
• this would be an area attack, I didn't want the direct hit to be a hexagon that can be occupied by a foe in order to avoid some confusion when dealing with blocks/wards/shields type of mechanics and to reinforce the animation.

At some point I recall I've even considered Intense Prayer's upgrade being rather OP and wanted to revamp it, but some fans opposed to the idea, saying they really like it like this xD

I could drop the "reuse" part between those two and just consider a more useful rename then; will tweak OP.

[allmtz]

I think the issue is not actually because of the different size of units, but that Intense Prayer affects a bigger area for several reasons:

• animation wise, Infernal will be hitting frontal-underneath hexagon

Dropping the size from the name, what do you think of frontAndBack8Hex and frontAndBack9Hex?

[DreadKnight]

Sounds good to me!

On Sun, Mar 3, 2024, 11:34 PM Allan Martinez @.***> wrote:

I think the issue is not actually because of the different size of units, but that Intense Prayer affects a bigger area for several reasons:

• animation wise, Infernal will be hitting frontal-underneath hexagon

Dropping the size from the name, what do you think of frontAndBack8Hex and frontAndBack9Hex?

— Reply to this email directly, view it on GitHub https://github.com/FreezingMoon/AncientBeast/issues/2557#issuecomment-1975340505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPNX7YDW64S3DFRY45I3TYWOJOFAVCNFSM6AAAAABECWULWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGM2DANJQGU . You are receiving this because you were mentioned.Message ID: @.***>