AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

double drop [bounty: 11 XTR]

Open DreadKnight opened this issue 1 year ago • 2 comments

Picking up a drop actually pics it twice. It shows up two times in the combat log and the end result actually reflects that. Screenshot_20240221_125518

DreadKnight avatar Feb 21 '24 11:02 DreadKnight

Hi @DreadKnight, I'm really a beginner to open source, and this project seems really interesting, can you please assign me this issue. I'd love to be a part of debugging issues for Ancient Beast 😄

codemaster321 avatar Feb 25 '24 07:02 codemaster321

@codemaster321 Heya! Will assign you right away. Open source ftw! 2 weeks soft deadline btw 🐻

DreadKnight avatar Feb 25 '24 12:02 DreadKnight

@codemaster321 Heya! Softdeadline passed, any progress?

DreadKnight avatar Mar 15 '24 14:03 DreadKnight

hi @DreadKnight, sorry for delayed reply, im finding it very difficult to find whats causing the pickup function to reexecute twice

codemaster321 avatar Mar 15 '24 22:03 codemaster321

@codemaster321 Alright, feel free to poke at another one then.

DreadKnight avatar Mar 16 '24 20:03 DreadKnight

Hi @DreadKnight , i think i have figured out the issue, and have found out a solution for it uncle_fungus

issue_fix

WIll give an update on it in a short while

codemaster321 avatar Mar 17 '24 06:03 codemaster321

@DreadKnight, Should i create a pull request or explain my approach like what did i do to fix the issue

codemaster321 avatar Mar 17 '24 07:03 codemaster321

Yeah, PRs are the way to go about it.

On Sun, Mar 17, 2024, 9:05 AM Shiv @.***> wrote:

@DreadKnight https://github.com/DreadKnight, Should i create a pull request or explain my approach like what did i do to fix the issue

— Reply to this email directly, view it on GitHub https://github.com/FreezingMoon/AncientBeast/issues/2548#issuecomment-2002337525, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPNX2AYZSAX46653NLWYLYYU6EJAVCNFSM6AAAAABDS4KIJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGMZTONJSGU . You are receiving this because you were mentioned.Message ID: @.***>

DreadKnight avatar Mar 17 '24 09:03 DreadKnight