AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

Published 20 hours ago • verified publisher icon FreezingMoon

#issue2174

Open Zelongczl opened this issue 2 years ago • 4 comments

This fixes issue #2174

Note: The click of passisve abilities, diabled abilities, noclick abilities, etc. will temporarily display cancel icon

Zelongczl avatar Oct 28 '23 09:10 Zelongczl

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Oct 28, 2023 9:34am

vercel[bot] avatar Oct 28 '23 09:10 vercel[bot]

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Oct 28 '23 09:10 ghost

@Zelongczl Heya! Seems pretty good, however, the cancel icon doesn't seem to for already used abilities as according to issue specs. It's nice that it also works for hotkeys, but it should trigger for the passive one (Q hotkey) if no abilities are usable atm. Note that it would be useful to merge master in to easier test your branch, since it had issue #2506 unsolved, which makes clicking passive and basic attack icons very hard without some tinkering around.

DreadKnight avatar Oct 30 '23 01:10 DreadKnight

@Zelongczl Heya! Can you poke at this a bit more so that we can finish with the PR before it goes stale?

DreadKnight avatar Feb 10 '24 09:02 DreadKnight