qol(sword-slitter): Added a 1 second delay before the second sword slitter

[JoelFernandes09]

After the delay the enemy takes damage along with a camera shake. Do we wanna add a game log here as well? Something like, "Bounty Hunter used a bonus Sword Slitter"?

Closes #2199

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ancientbeast	✅ Ready (Inspect)	Visit Preview	Nov 2, 2023 9:13am

[ghost]

👇 Click on the image for a new way to code review

Legend

[DreadKnight]

Good idea, we could have it as "Bounty Hunter used Sword Slitter twice".

[DreadKnight]

Tested and something odd seems to happen if Bounty Hunter kills target unit with the first hit: there's camera shake after 1s; so obviously, shake should happen on first hit only and no more shake after 1s.

[JoelFernandes09]

@DreadKnight Should be good to go now! Added a target dead check in so the second hit is only trigger if the target is alive.

[DreadKnight]

@JoelFernandes09 Did more testing. Found one more issue, if Bounty Hunter kills the target using the second hit, a tooltip "Canceled" shows up pointlessly. That tooltip is used when toggling an ability off in various ways, never after abilities used.

[JoelFernandes09]

@DreadKnight Gotcha, will look into this

[DreadKnight]

@JoelFernandes09 Heya! Any progress with this? Eventually PRs go stale and get closed...

[JoelFernandes09]

Hey there! My apologies. I'll take a look at this & push the fix tomorrow itself. @DreadKnight

[JoelFernandes09]

@DreadKnight Apologies for such a delay here. Should be good now!

[DreadKnight]

@JoelFernandes09 I've tested this and second attack that would kill the target doesn't happen at all. Needs more work...

[DreadKnight]

@JoelFernandes09 Heya! Can you poke at this so we can finish with it before it goes stale?