AncientBeast icon indicating copy to clipboard operation
AncientBeast copied to clipboard

build id inside saved match logs

Open DreadKnight opened this issue 3 years ago • 3 comments
trafficstars

Would be neat if we can include something like the id of the latest GitHub commit (or a build id) into the saved match logs.

DreadKnight avatar Dec 03 '21 11:12 DreadKnight

If we manage something like this or an easy type of hash or identification code, we could have the game provide a warning when players try to load a match log that has a different one. At some point in the future we might even provide a way to fetch and temporary build that specific version and pass it the match log, in order to make sure that match logs will be usable even if old.

DreadKnight avatar Dec 03 '21 11:12 DreadKnight

I've bumped into https://wallet.zksync.io recently that actually uses a similar approach, as it displays the exact GitHub commit id/hash thingy as a link, right next to the official version number (lower right corner, just like we here with Ancient Beast). So their source code could be checked out on GitHub and maybe figure out how to actually get that id/hash automatically. Screenshot_20211223_040143

DreadKnight avatar Dec 23 '21 02:12 DreadKnight

Game would store some build related hash each time there's a PR merged in, since git has some randomly generated codes for commits, so we could include that in the saves somewhere around the version number, that way we could be very specific about the build used to generate that game log and hopefully at some point it would be dead easy to replay old game logs as well by having some git related service our tool to fetch and build specific commit required.

DreadKnight avatar Jun 02 '23 22:06 DreadKnight